generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wsaw ui css changes #1292
Merged
Merged
wsaw ui css changes #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Lakshmi,
Great start, thank you for this, I have been testing the changes here:
https://ui-chgs-wsaw--danaher-ls-aem--hlxsites.hlx.page/us/en/we-see-a-way/details
https://ui-chgs-wsaw--danaher-ls-aem--hlxsites.hlx.page/us/en/solutions/mabs/cell-line-development
I only have one change if OK: the text-3xl isn’t taking affect. I think this is because !text-base is still in the same class line, so that is overriding this. Can you please remove text-base and this should work?
Once that is done, please commit, let us know and I will ask @Delaura, Anthony ***@***.***> to review the changes.
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_748506198]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_2285152939] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_3324510127] <https://www.youtube.com/user/danahercorporation> [signature_3678325241] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_214277548]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_1113892739] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_2036190750] <https://www.youtube.com/user/danahercorporation> [signature_2075236148] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_1481569638]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_2306629992] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_3372267393] <https://www.youtube.com/user/danahercorporation> [signature_3674591642] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
Confidential - Company Proprietary
From: lakshmithi ***@***.***>
Date: Tuesday, 5 November 2024 at 17:20
To: hlxsites/danaher-ls-aem ***@***.***>
Cc: Nichols, Dave ***@***.***>, Review requested ***@***.***>
Subject: Re: [hlxsites/danaher-ls-aem] wsaw ui css changes (PR #1292)
@ lakshmithi requested your review on: #1292 wsaw ui css changes. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested. Message ID: <hlxsites/danaher-ls-aem/pull/1292/issue_event/15124090470@ github. com>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization. Use caution when opening.
ZjQcmQRYFpfptBannerEnd
@lakshmithi<https://urldefense.com/v3/__https:/github.com/lakshmithi__;!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSULgHRsR$> requested your review on: #1292<https://urldefense.com/v3/__https:/github.com/hlxsites/danaher-ls-aem/pull/1292__;!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSaYzlnoW$> wsaw ui css changes.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/hlxsites/danaher-ls-aem/pull/1292*event-15124090470__;Iw!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSWyg8rIw$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A5YJPYXDJJXOFMVFCUJ74WTZ7D47NAVCNFSM6AAAAABRHBNNUSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGEZDIMBZGA2DOMA__;!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSa6clCqD$>.
You are receiving this because your review was requested.Message ID: ***@***.***>
Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.
|
Hi Lakshmi,
Thank you for this, I can see the UX change for the font now as well.
@Delaura, Anthony ***@***.***> – can you please review these pages with the left/right column changes and how they appear:
https://ui-chgs-wsaw--danaher-ls-aem--hlxsites.hlx.page/us/en/we-see-a-way/details
https://ui-chgs-wsaw--danaher-ls-aem--hlxsites.hlx.page/us/en/solutions/mabs/cell-line-development
Thanks,
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_3582576567]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_3736679931] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_1549245312] <https://www.youtube.com/user/danahercorporation> [signature_3809524192] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
Confidential - Company Proprietary
From: Nichols, Dave ***@***.***>
Date: Wednesday, 6 November 2024 at 10:30
To: hlxsites/danaher-ls-aem ***@***.***>, hlxsites/danaher-ls-aem ***@***.***>, Thiagarajan, Lakshminarayanan ***@***.***>, Delaura, Anthony D ***@***.***>
Subject: Re: [hlxsites/danaher-ls-aem] wsaw ui css changes (PR #1292)
Hi Lakshmi,
Great start, thank you for this, I have been testing the changes here:
https://ui-chgs-wsaw--danaher-ls-aem--hlxsites.hlx.page/us/en/we-see-a-way/details
https://ui-chgs-wsaw--danaher-ls-aem--hlxsites.hlx.page/us/en/solutions/mabs/cell-line-development
I only have one change if OK: the text-3xl isn’t taking affect. I think this is because !text-base is still in the same class line, so that is overriding this. Can you please remove text-base and this should work?
Once that is done, please commit, let us know and I will ask @Delaura, Anthony ***@***.***> to review the changes.
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_748506198]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_2285152939] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_3324510127] <https://www.youtube.com/user/danahercorporation> [signature_3678325241] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_214277548]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_1113892739] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_2036190750] <https://www.youtube.com/user/danahercorporation> [signature_2075236148] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
Dave Nichols
Manager, CXC (Customer Experience and Commerce) Web and Content
P — +44 23 9400 6813
C — +44 7900527717
Supporting the Life Sciences Companies of Danaher
[signature_1481569638]
2200 Pennsylvania Ave, NW Suite 88W
Washington, DC 20037
www.danaher.com<http://www.danaher.com/>
[A purple circle with white letters on it Description automatically generated]<https://www.linkedin.com/company/danaher/> [signature_2306629992] <https://twitter.com/DanaherCorp?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor> [signature_3372267393] <https://www.youtube.com/user/danahercorporation> [signature_3674591642] <https://www.facebook.com/danahercorporation>
Innovation at the speed of life™
From: lakshmithi ***@***.***>
Date: Tuesday, 5 November 2024 at 17:20
To: hlxsites/danaher-ls-aem ***@***.***>
Cc: Nichols, Dave ***@***.***>, Review requested ***@***.***>
Subject: Re: [hlxsites/danaher-ls-aem] wsaw ui css changes (PR #1292)
@ lakshmithi requested your review on: #1292 wsaw ui css changes. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested. Message ID: <hlxsites/danaher-ls-aem/pull/1292/issue_event/15124090470@ github. com>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization. Use caution when opening.
ZjQcmQRYFpfptBannerEnd
@lakshmithi<https://urldefense.com/v3/__https:/github.com/lakshmithi__;!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSULgHRsR$> requested your review on: #1292<https://urldefense.com/v3/__https:/github.com/hlxsites/danaher-ls-aem/pull/1292__;!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSaYzlnoW$> wsaw ui css changes.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/hlxsites/danaher-ls-aem/pull/1292*event-15124090470__;Iw!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSWyg8rIw$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A5YJPYXDJJXOFMVFCUJ74WTZ7D47NAVCNFSM6AAAAABRHBNNUSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGEZDIMBZGA2DOMA__;!!G8Er-fQLpA!NG-8uv-vubY5lLiqmlgeqj7FgaCsoRsYo62tNzJNkT4uVozYKo7FdU8Mc0q7goJKz1KsSSPSNEROqKAgTcAydQgYSa6clCqD$>.
You are receiving this because your review was requested.Message ID: ***@***.***>
Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.
|
rgravitvl
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: